Fix #1933, Remove unreachable/dead branch in CFE_ES_RunPerfLogDump()
#2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
requested changes
Jul 17, 2023
There was a problem hiding this comment.
Recommend updating lines/branches coverage check in CI:
cFE/.github/workflows/code-coverage.yml
Lines 107 to 108 in f6d7f8c
Note even without this update main looks like it's 1 line and 1 branch out of date. See https://github.com/nasa/cFE/actions/runs/5570239970/jobs/10174148336 which shows 17 and 51 (vs 18 and 52).
See https://github.com/nasa/cFE/actions/runs/4899459045/jobs/8749435100#step:9:160 shows 17 and 50 with this update.
thnkslprpt
force-pushed
the
fix-1933-remove-dead-branch-in-CFE_ES_RunPerfLogDump
branch
from
0d01cfe
to
d5e12de
Compare
thnkslprpt
force-pushed
the
fix-1933-remove-dead-branch-in-CFE_ES_RunPerfLogDump
branch
from
d5e12de
to
870c878
Compare
Good point @skliper Updated now. |
skliper
approved these changes
Jul 18, 2023
|
Note: may need to lower the coverage minimums further if other PRs that improve coverage are merged before this one. |
jphickey
approved these changes
Feb 15, 2024
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
This was referenced Feb 23, 2024
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Feb 23, 2024
*Combines:* cFE equuleus-rc1+dev96 osal equuleus-rc1+dev53 to_lab equuleus-rc1+dev44 **Includes:** *cFE* - nasa/cFE#2515 - nasa/cFE#2330 *osal* - nasa/osal#1448 - nasa/osal#1146 - nasa/osal#1357 - nasa/osal#1354 - nasa/osal#1331 *to_lab* - nasa/to_lab#191 - nasa/to_lab#136 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Sam Price <thesamprice@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Feb 23, 2024
*Combines:* cFE equuleus-rc1+dev96 osal equuleus-rc1+dev53 to_lab equuleus-rc1+dev44 **Includes:** *cFE* - nasa/cFE#2515 - nasa/cFE#2330 *osal* - nasa/osal#1448 - nasa/osal#1146 - nasa/osal#1357 - nasa/osal#1354 - nasa/osal#1331 *to_lab* - nasa/to_lab#191 - nasa/to_lab#136 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Sam Price <thesamprice@users.noreply.github.com>
thnkslprpt
deleted the
fix-1933-remove-dead-branch-in-CFE_ES_RunPerfLogDump
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CurrentStatecan be>= CFE_ES_PerfDumpState_CLEANUP- making the negative branch here unreachableTesting performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
This PR (slightly) increases coverage by one branch by removing an unreachable branch.
Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt